[Storage] Another fix to flaky retry test #25940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jalauzon-msft
requested review from
annatisch and
vincenttran-msft
as code owners
ghost
added
the
vincenttran-msft
approved these changes
Aug 29, 2022
|
/azp run python - storage - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mccoyp
pushed a commit
to mccoyp/azure-sdk-for-python
that referenced
this pull request
Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason the socket retry test was sometimes failing when trying to delete the container saying the resource did not exist. I think this was because the timeout on the client was not properly being reset and so the first request may time out reading the response, but the service would still delete the container. The retry would then get the resource does not exist error.
This change constructs a new client with normal timeouts.